[DaanHoogland]

Depends on #14555

Description

Third PR of the stack: the code-style cleanups that were mixed into an earlier version of #12500, split out so they can be reviewed (or declined) on their own. Based on the Ovm/Ovm3 PR; review only the last commit.

Files: ApiResponseHelper, Upgrade410to420, AffinityGroupServiceImpl, SystemVmTemplateRegistration.

Mostly mechanical: diamond operators, logger placeholders, redundant try-with-resources semicolons, isEmpty(), multi-catch. Changes that go beyond that:

• ApiResponseHelper: several capability/service response blocks are extracted into private static helpers. Two commented-out createUserVmResponse overloads are deleted.
• Upgrade410to420: the string if/else chains become switch statements (same null behaviour as the .equals() calls they replace). The unused dropUploadTable() and the supportsRollingUpgrade() override are removed (the interface default also returns false). Repeated messages become constants.

Note: Upgrade410to420 is a historic upgrade path, so the changes there buy little and some reviewers may prefer to leave it alone.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

🤖 Generated with Claude Code

[codecov]

Codecov Report

❌ Patch coverage is 4.95050% with 192 lines in your changes missing coverage. Please review.
✅ Project coverage is 20.86%. Comparing base (24e830a) to head (749f2d1).

Files with missing lines	Patch %	Lines
...src/main/java/com/cloud/api/ApiResponseHelper.java	2.12%	184 Missing ⚠️
...om/cloud/upgrade/SystemVmTemplateRegistration.java	20.00%	4 Missing ⚠️
.../cloudstack/affinity/AffinityGroupServiceImpl.java	55.55%	4 Missing ⚠️

Additional details and impacted files

@@                    Coverage Diff                    @@
##             removeOvmLeftovers   #14556       +/-   ##
=========================================================
+ Coverage                  3.88%   20.86%   +16.97%     
- Complexity                    0    21915    +21915     
=========================================================
  Files                       493     6470     +5977     
  Lines                     42571   589005   +546434     
  Branches                   8069    72210    +64141     
=========================================================
+ Hits                       1653   122883   +121230     
- Misses                    40687   452785   +412098     
- Partials                    231    13337    +13106     

Flag	Coverage Δ
uitests	3.88% <ø> (ø)
unittests	22.18% <4.95%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

🔴 Test Coverage Grade: D — Marginal

Metric	Value
Line coverage	26.04%
Branch coverage	20.32%

Grade Scale

Grade	Line Coverage	Meaning
🟢 A	≥ 80%	Excellent - this code sleeps well at night 😴
🟡 B	60-79%	Good - almost there, don't stop now 😉
🟠 C	40-59%	Acceptable - your code is wearing a seatbelt, but no airbags 😬
🔴 D	20-39%	Marginal - boldly shipping where no test has gone before 🖖
⛔ F	< 20%	Failing - tests? what tests? 🔥

Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

[sonarqubecloud]

Quality Gate failed

Failed conditions
1.4% Coverage on New Code (required ≥ 40%)
C Maintainability Rating on New Code (required ≥ B)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE