Repository navigation
refactor!: tidy table provider constructors and stale names - #110
Merged
gabotechs merged 1 commit intoNov 18, 2026
Merged
Conversation
- Make IcebergStaticTableProvider::try_new_from_table and try_new_from_table_snapshot synchronous; neither awaited anything. - Replace IcebergMetadataTableProvider::new with a fallible try_new that converts the schema once, so TableProvider::schema no longer unwraps. - Replace the old IcebergTableProvider name in error messages and docs, and refresh other stale names in AGENTS.md.
Contributor
Author
|
cc @gabotechs: starting a series of small, easy-to-merge cleanups. After that I'll take on the bigger refactors you've been steering toward in #67 and #48. Future refactor PR's may overlap with some of these cleanups, but I just want to sort out the gunk first. |
mbutrovich
approved these changes
Nov 17, 2026
mbutrovich
left a comment
Contributor
There was a problem hiding this comment.
Thanks @NoahKusaba, this is a nice cleanup. Moving the metadata schema conversion into try_new so planning can't panic is the right call.
Contributor
|
I renamed it to track the breaking change. |
gabotechs
approved these changes
Nov 18, 2026
gabotechs
left a comment
Contributor
There was a problem hiding this comment.
Nice, thanks @NoahKusaba and @mbutrovich!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
IcebergStaticTableProvider's two constructors areasyncbut never await anything.IcebergMetadataTableProvider::schema()unwrap()s a schema conversion on every call. It should fail at construction, not panic during planning.IcebergTableProvider, andAGENTS.mdhas other stale names.What changes are included in this PR?
try_new_from_tableandtry_new_from_table_snapshotare synchronous.IcebergMetadataTableProvider::newbecomestry_new, which converts the schema once and stores it.AGENTS.md.Are there any user-facing changes?
Yes: drop
.awaitafter the static provider constructors, and useIcebergMetadataTableProvider::try_new(..)?instead ofnew(..).Are these changes tested?
Yes, by the existing tests, updated for the new signatures and error message.