Repository navigation
Refactor DataFusion crate folder structure - #49
Merged
Merged
Conversation
gabotechs
commented
Oct 7, 2026
| /// For catalog-backed tables with write support and automatic refresh, use | ||
| /// [`IcebergTableProvider`](super::IcebergCatalogTableProvider) instead. | ||
| #[derive(Debug, Clone)] | ||
| pub struct IcebergStaticTableProvider { |
Contributor
Author
There was a problem hiding this comment.
Factored out from crates/datafusion/src/table/mod.rs untouched.
| /// For catalog-backed tables with write support and automatic refresh, use | ||
| /// [`IcebergTableProvider`] instead. | ||
| #[derive(Debug, Clone)] | ||
| pub struct IcebergStaticTableProvider { |
Contributor
Author
There was a problem hiding this comment.
Moved to static_table_provider.rs untouched
| use tempfile::TempDir; | ||
|
|
||
| use super::*; | ||
|
|
||
| async fn get_test_table_from_metadata_file() -> Table { |
Contributor
Author
There was a problem hiding this comment.
Moved to static_table_provider.rs untouched
alamb
approved these changes
Oct 9, 2026
alamb
left a comment
Contributor
There was a problem hiding this comment.
Thanks @gabotechs and @NoahKusaba
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reorganizes the module structure of the project to something more granular, with the intention of improving visual indexing and better clarifying where should the different pieces be contributed.
The new module structure looks like this: