You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Epic] A collection of issues for extending the Aggregation function #12254
Is your feature request related to a problem or challenge?
DataFusion now supports several aggregation functions, but it still lacks some common ones that are essential for a broader range of data processing tasks. To make DataFusion more versatile and capable of handling diverse workloads, it should include additional aggregation functions commonly used in data analysis, such as mode and max_by.
changed the title [-][Epic] Extend the Aggregation function[/-][+][Epic] A collection of issues for extending the Aggregation function[/+]on Aug 30, 2024
I wonder if we should consider where to draw the line on what aggregate functions to include in the core (i.e. should we include all these new functions?)
Now that all aggregate functions use the same API, we could potentially keep more specialized functions such as listed here outside the ore -- either in its own crate or even own repo -- and then have other code integrate it in -- e.g. #11979
I wonder if we should consider where to draw the line on what aggregate functions to include in the core (i.e. should we include all these new functions?)
Now that all aggregate functions use the same API, we could potentially keep more specialized functions such as listed here outside the ore -- either in its own crate or even own repo -- and then have other code integrate it in -- e.g. #11979
Thank you @alamb for proposing this initiative. I like this idea. What about others' thought?
It clearly draws a line between the core and the extensions. And we can still leverage those functions as extension in dft.
@alamb
I’m generally in favor of moving additional features from the core to separate subprojects. However, could we consider using a more general name than datafusion-functions-duckdb? What are your thoughts on using something like datafusion-functions-sql or another broader name?
@alamb I’m generally in favor of moving additional features from the core to separate subprojects. However, could we consider using a more general name than datafusion-functions-duckdb? What are your thoughts on using something like datafusion-functions-sql or another broader name?
I do not have a strong preference -- I think it likely depends on the usecase:
trying to migrate spark workloads
trying to migrate duckdb workloads
triynt to make the most useful sql system you can
However, let's not let get too carried away with details at the moment.
@alamb I’m generally in favor of moving additional features from the core to separate subprojects. However, could we consider using a more general name than datafusion-functions-duckdb? What are your thoughts on using something like datafusion-functions-sql or another broader name?
I do not have a strong preference -- I think it likely depends on the usecase:
trying to migrate spark workloads
trying to migrate duckdb workloads
triynt to make the most useful sql system you can
However, let's not let get too carried away with details at the moment.
And then try to put the mode function there: #12385
I agree that 'datafusion-functions-extra' is sufficient for the current scenario because our goal is to decouple the extra functions from the core and make them lightweight. Additionally, it would be easier to split 'datafusion-functions-extra' into many specific use cases if necessary.
Activity
[-][Epic] Extend the Aggregation function[/-][+][Epic] A collection of issues for extending the Aggregation function[/+]alamb commentedon Sep 5, 2024
I wonder if we should consider where to draw the line on what aggregate functions to include in the core (i.e. should we include all these new functions?)
Now that all aggregate functions use the same API, we could potentially keep more specialized functions such as listed here outside the ore -- either in its own crate or even own repo -- and then have other code integrate it in -- e.g. #11979
alamb commentedon Sep 6, 2024
I started a discussion about if we should be adding all these functions directly in the core here: #12357
Weijun-H commentedon Sep 6, 2024
I like this idea! 🚀
alamb commentedon Sep 16, 2024
@Weijun-H and @dmitrybugakov and @dharanad -- what do you think about creating a
datafusion-functions-duckdbrepo in datafusion-contrib similar to https://github.com/datafusion-contrib/datafusion-functions-json for JSON from @samuelcolvin and co.It would be a pretty neat way to help build out the function library in DataFUsion and would show off its extensibility
I could then try an integrate it into
dftthat @matthewmturner and I have been working on: https://github.com/datafusion-contrib/datafusion-dft which would make it easer to useOriginally from: #12476 (comment)
austin362667 commentedon Sep 16, 2024
Thank you @alamb for proposing this initiative. I like this idea. What about others' thought?
It clearly draws a line between the
coreand theextensions. And we can still leverage those functions as extension indft.s5dsn-eqee commentedon Sep 17, 2024
@alamb
I’m generally in favor of moving additional features from the core to separate subprojects. However, could we consider using a more general name than datafusion-functions-duckdb? What are your thoughts on using something like datafusion-functions-sql or another broader name?
alamb commentedon Sep 17, 2024
I do not have a strong preference -- I think it likely depends on the usecase:
However, let's not let get too carried away with details at the moment.
I created https://github.com/datafusion-contrib/datafusion-functions-extra and added @dmitrybugakov and @austin362667 as admins. If anyone else wants to help let me know and we can add you too.
@dmitrybugakov or @austin362667 would you be willing to setup the basic skeleton of the repo?
Perhaps you could follow the model of https://github.com/datafusion-contrib/datafusion-functions-json for readme and registration function
And then try to put the
modefunction there: #12385alamb commentedon Sep 17, 2024
Update: I also added @Lordworms (a longtime DataFusion contributor) per #12284 (comment)
Weijun-H commentedon Sep 18, 2024
I agree that 'datafusion-functions-extra' is sufficient for the current scenario because our goal is to decouple the extra functions from the core and make them lightweight. Additionally, it would be easier to split 'datafusion-functions-extra' into many specific use cases if necessary.
alamb commentedon Sep 25, 2024
I believe the consensus is that we are going to implement these functions in https://github.com/datafusion-contrib/datafusion-functions-extra -- I will close the related tickets so we are not confusing people about what we are looking for
alamb commentedon Sep 25, 2024
I filed #12625 to propose moving
kertosis_pop