Skip to content

implement max/min_by aggregate function - #12284

Closed
Lordworms wants to merge 4 commits into
apache:mainfrom
Lordworms:issue_12254
Closed

Lordworms wants to merge 4 commits into
apache:mainfrom
Lordworms:issue_12254

Conversation

@Lordworms

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Closes #12252

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions Bot added sqllogictest SQL Logic Tests (.slt) functions Changes to functions implementation labels Sep 2, 2024
@Lordworms

Copy link
Copy Markdown
Contributor Author

repushed it

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Sep 5, 2024
@Lordworms Lordworms changed the title implement max_by aggregate function implement max/min_by aggregate function Sep 5, 2024
@Lordworms

Copy link
Copy Markdown
Contributor Author

An unrelated ci problem

@alamb

alamb commented Sep 16, 2024

Copy link
Copy Markdown
Contributor

I wonder if this would be a good candidate to start building a new datafusion-functions-spark crate in https://github.com/datafusion-contrib? It would be really neat if we could start filling that out (I bet the Comet team would potentially be interested too -- cc @andygrove )

Let me know and I could make you a repo

@Lordworms

Lordworms commented Sep 16, 2024 •

Copy link
Copy Markdown
Contributor Author

I wonder if this would be a good candidate to start building a new datafusion-functions-spark crate in https://github.com/datafusion-contrib? It would be really neat if we could start filling that out (I bet the Comet team would potentially be interested too -- cc @andygrove )

Let me know and I could make you a repo

I think it would be optimal, cc me when the repo is ready. Thanks a lot!

@alamb

alamb commented Sep 17, 2024

Copy link
Copy Markdown
Contributor

Aweomse -- I made datafusion-functions-extra and added you.

See #12254 (comment) for discussion with @dmitrybugakov and @austin362667

@Lordworms

Copy link
Copy Markdown
Contributor Author

Aweomse -- I made datafusion-functions-extra and added you.

See #12254 (comment) for discussion with @dmitrybugakov and @austin362667

Thanks, I'll add the function there.

@alamb alamb closed this Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation functions Changes to functions implementation sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support max_by in Aggregation function

4 participants