Skip to content

feat(rest): parse catalog labels from load table response - #3688

Open
fredpower44 wants to merge 1 commit into
apache:mainfrom
fredpower44:catalog-labels-serde
Open

fredpower44 wants to merge 1 commit into
apache:mainfrom
fredpower44:catalog-labels-serde

Conversation

@fredpower44

@fredpower44 fredpower44 commented Nov 13, 2026 •

Copy link
Copy Markdown

Which issue does this PR close?

What changes are included in this PR?

Parses the optional labels field of LoadTableResult, added to the REST spec in apache/iceberg#15750,
into new Labels and FieldLabels types in the iceberg crate. Parsing matches Java: a missing or null
labels, object-labels or fields reads as empty, and each field entry requires field-id and
labels. A follow-up PR will expose labels on Table.

Are these changes tested?

Yes. Unit tests cover the label types (JSON round trip, missing and null parts, required keys in field
entries) and LoadTableResult with and without labels.

AI Disclosure

Code, tests were drafted with Claude Code (Claude Opus 5.5). I reviewed the changes.

@fredpower44

Copy link
Copy Markdown
Author

@laskoviymishka Hi Andrei, looking to get involved in iceberg, so I picked up this as a starter task. Would you mind reviewing this / pointing me to the right reviewers?

@laskoviymishka
laskoviymishka self-requested a review November 13, 2026 22:30
@laskoviymishka

Copy link
Copy Markdown
Contributor

@fredpower44 this would be on me

@laskoviymishka laskoviymishka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fredpower44 for picking this up. As I read it, the serde rules accept and reject the same inputs as Java's LabelsParser and FieldLabelParser, and a LoadTableResult without labels serializes the same as on main.

@laskoviymishka laskoviymishka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fredpower44 for picking this up. As I read it, the serde rules accept and reject the same inputs as Java's LabelsParser and FieldLabelParser, and a LoadTableResult without labels serializes the same as on main.

@fredpower44 fredpower44 changed the title Parse Catalog labels in LoadTableResult response feat(rest): parse catalog labels from load table response Nov 16, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants