Repository navigation
feat(rest): parse catalog labels from load table response - #3688
Open
fredpower44 wants to merge 1 commit into
Open
fredpower44 wants to merge 1 commit into
fredpower44 wants to merge 1 commit into
Conversation
Author
|
@laskoviymishka Hi Andrei, looking to get involved in iceberg, so I picked up this as a starter task. Would you mind reviewing this / pointing me to the right reviewers? |
laskoviymishka
self-requested a review
November 13, 2026 22:30
Contributor
|
@fredpower44 this would be on me |
laskoviymishka
approved these changes
Nov 14, 2026
laskoviymishka
left a comment
Contributor
There was a problem hiding this comment.
Thanks @fredpower44 for picking this up. As I read it, the serde rules accept and reject the same inputs as Java's LabelsParser and FieldLabelParser, and a LoadTableResult without labels serializes the same as on main.
laskoviymishka
approved these changes
Nov 14, 2026
laskoviymishka
left a comment
Contributor
There was a problem hiding this comment.
Thanks @fredpower44 for picking this up. As I read it, the serde rules accept and reject the same inputs as Java's LabelsParser and FieldLabelParser, and a LoadTableResult without labels serializes the same as on main.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Parses the optional
labelsfield ofLoadTableResult, added to the REST spec in apache/iceberg#15750,into new
LabelsandFieldLabelstypes in theicebergcrate. Parsing matches Java: a missing or nulllabels,object-labelsorfieldsreads as empty, and each field entry requiresfield-idandlabels. A follow-up PR will expose labels onTable.Are these changes tested?
Yes. Unit tests cover the label types (JSON round trip, missing and null parts, required keys in field
entries) and
LoadTableResultwith and withoutlabels.AI Disclosure
Code, tests were drafted with Claude Code (Claude Opus 5.5). I reviewed the changes.