Repository navigation
Catalog labels table - #3703
Open
fredpower44 wants to merge 2 commits into
Open
Catalog labels table#3703fredpower44 wants to merge 2 commits into
fredpower44 wants to merge 2 commits into
Conversation
Add Table::labels() and TableBuilder::labels(), and set them from the LoadTableResult returned by the REST catalog's load_table, create_table and register_table, so callers can read the labels a catalog returns. Generated-by: Claude Code (Claude Opus 5.5) Co-authored-by: Isaac <no-reply@databricks.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
feat(rest): expose catalog labels on Table, is new.What changes are included in this PR?
Adds
Table::labels()andTableBuilder::labels(), and sets labels from theLoadTableResultreturnedby REST
load_table,create_tableandregister_table. Because labels live onTable, a reloadserved from the ETag cache returns the cached labels. A table returned by a commit has no labels, because
the commit response doesn't include them; Go and C++ behave the same way. Happy to carry them over in
Transaction::commitinstead if that's preferred.Are these changes tested?
Yes. REST catalog tests cover labels from load, create and register, and
Nonewhen the response has nolabels.
AI Disclosure
Code, tests and this description were drafted with Claude Code (Claude Opus 5.5). I reviewed.