Repository navigation
refactor(pypi): do not parse the versions to select the wheels - #4557
Merged
Merged
Conversation
Only the major and the minor numbers of the Python version are needed to match the Python tags of the wheels, so get them directly instead of using a PEP 440 version parser. This means that `select_whl`, which is used by `coverage_deps.bzl` when `python/repositories.bzl` is loaded in a `WORKSPACE` file, will not need `pypackaging.bzl` once `version.bzl` is replaced with it.
Collaborator
Author
This was referenced Nov 21, 2026
rickeylev
reviewed
Nov 21, 2026
rickeylev
approved these changes
Nov 21, 2026
…ackaging-01-select-whl
aignas
commented
Nov 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only the major and the minor numbers of the Python version are needed to
match the Python tags of the wheels, so get them directly instead of
using a PEP 440 version parser.
This means that
select_whl, which is used bycoverage_deps.bzlwhen
python/repositories.bzlis loaded in aWORKSPACEfile, willnot need
pypackaging.bzlonceversion.bzlis replaced with it.