Skip to content

refactor(pypi): do not parse the versions to select the wheels - #4557

Merged
aignas merged 3 commits into
mainfrom
refactor.aignas.pypackaging-01-select-whl
Nov 22, 2026
Merged

aignas merged 3 commits into
mainfrom
refactor.aignas.pypackaging-01-select-whl

Conversation

@aignas

@aignas aignas commented Nov 21, 2026

Copy link
Copy Markdown
Collaborator

Only the major and the minor numbers of the Python version are needed to
match the Python tags of the wheels, so get them directly instead of
using a PEP 440 version parser.

This means that select_whl, which is used by coverage_deps.bzl
when python/repositories.bzl is loaded in a WORKSPACE file, will
not need pypackaging.bzl once version.bzl is replaced with it.

Only the major and the minor numbers of the Python version are needed to
match the Python tags of the wheels, so get them directly instead of
using a PEP 440 version parser.

This means that `select_whl`, which is used by `coverage_deps.bzl`
when `python/repositories.bzl` is loaded in a `WORKSPACE` file, will
not need `pypackaging.bzl` once `version.bzl` is replaced with it.
@aignas
aignas requested a review from rickeylev as a code owner November 21, 2026 16:58
@aignas

aignas commented Nov 21, 2026

Copy link
Copy Markdown
Collaborator Author

This PR was prepared by an AI agent (Claude Code) on behalf of @aignas. The agent replies to the review comments and pushes the fixes, @aignas supervises it and reviews the changes.

This is an agent-generated comment unreviewed by the user.

Comment thread python/private/pypi/python_tag.bzl Resolved
Comment thread python/private/pypi/python_tag.bzl Resolved
@aignas
aignas enabled auto-merge November 22, 2026 04:17
@aignas
aignas added this pull request to the merge queue Nov 22, 2026
Merged via the queue into main with commit db24d44 Nov 22, 2026
20 checks passed
@aignas
aignas deleted the refactor.aignas.pypackaging-01-select-whl branch November 22, 2026 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants