Skip to content

Prepare release of 5.0.0 for willdurand/geocoder - #1209

Merged
jbelien merged 9 commits into
geocoder-php:masterfrom
Nyholm:release-500
Jan 1, 2025
Merged

jbelien merged 9 commits into
geocoder-php:masterfrom
Nyholm:release-500

Conversation

@Nyholm

@Nyholm Nyholm commented Dec 21, 2023 •

Copy link
Copy Markdown
Member

Is there anything else we should add here?

geocoder-php/php-common@4.6.0...master

@Nyholm
Nyholm requested a review from jbelien December 21, 2023 12:20
@jbelien

jbelien commented Dec 28, 2023

Copy link
Copy Markdown
Member

I'll investigate the checks that are failing on PHP 8.2 but the tests for BingMaps seems to fail only on PHP 8.3.

  1. Geocoder\Provider\BingMaps\Tests\BingMapsTest::testGeocodeWithRealAddressReturnsMultipleResults
    unserialize(): Extra data starting at offset 3984 of 3985 bytes

@Chris53897

Copy link
Copy Markdown
Contributor

@jbelien I guess it was wrong all the time and just popped up with PHP 8.3.
https://php.watch/versions/8.3/unserialize-E-WARNING

I did create a PR (see above) to solve this.
I am not sure if this is the best way. But i could not figure out where the LINE Carriage (i guess) at the File-End is created in the first place.

@jbelien

jbelien commented Mar 2, 2024

Copy link
Copy Markdown
Member

✅ We're back on track: #1220

@Nyholm

Nyholm commented Oct 7, 2024

Copy link
Copy Markdown
Member Author

I've rebased the PR.

@jbelien please merge if you think we are ready.

Comment thread .github/workflows/component.yml Resolved
@jbelien
jbelien merged commit f2114ac into geocoder-php:master Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants