Skip to content

feat: allow "willdurand/geocoder" v5 - #1240

Merged
Nyholm merged 2 commits into
geocoder-php:masterfrom
Chris53897:feature/provider-geocode-5
Feb 11, 2025
Merged

Nyholm merged 2 commits into
geocoder-php:masterfrom
Chris53897:feature/provider-geocode-5

Conversation

@Chris53897

Copy link
Copy Markdown
Contributor

Follow-up for #1209

While i try to use it in symfony with https://github.com/geocoder-php/BazingaGeocoderBundle/blob/master/composer.json
i noticed that the provider need to be updated to.
Or do i miss something?

@Chris53897

Chris53897 commented Jan 9, 2025 •

Copy link
Copy Markdown
Contributor Author

@jbelien Sorry to nag you. But working in dev with PHP 8.4 is annoying. I need to reload the pages a lot. Because of the deprecation-info page.
Warning

Is there anything i can do, to push things forward?

@norkunas

Copy link
Copy Markdown
Member

@jbelien ping

@Nyholm Nyholm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Nyholm
Nyholm enabled auto-merge (squash) February 11, 2025 10:10
@Nyholm
Nyholm merged commit b722a3c into geocoder-php:master Feb 11, 2025
@norkunas

Copy link
Copy Markdown
Member

Thanks @Nyholm for taking care

@Chris53897
Chris53897 deleted the feature/provider-geocode-5 branch February 11, 2025 10:29
@Chris53897

Copy link
Copy Markdown
Contributor Author

thanks. are there plans for a new release?
Otherwise i could use my fork of https://github.com/geocoder-php/BazingaGeocoderBundle to integrate the dev-master.

@Nyholm

Nyholm commented Feb 15, 2025

Copy link
Copy Markdown
Member

Did you test it? Does it work for you?

If it does, it would bring me more confidence to do a release

@Chris53897

Copy link
Copy Markdown
Contributor Author

That is understandable.

I have created a PR but i did not figure out yet how to get dev-master from the single packages. I guess because of the alias.
https://github.com/geocoder-php/nominatim-provider/blob/master/composer.json#L29C13-L29C36

@kornrunner

Copy link
Copy Markdown
Contributor

Did you test it? Does it work for you?

I've tested using Nominatim provider. In order to get the newest versions I've used following constraints in composer.json:

"geocoder-php/nominatim-provider": "dev-master",
"geocoder-php/common-http": "dev-master as 4.6",

As far as I've tested - everything is ok. Hope this helps, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants