Repository navigation
chore: update messages on automated/official PRs - #2665
Conversation
efa8cba to
78941b5
Compare
| issue-number: ${{ github.event.pull_request.number }} | ||
| body: | | ||
| Created PR on the official-images repo (${{ steps.create-pr.outputs.pull-request-url }}). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub. | ||
| Created PR on the official-images repo (${{ steps.create-pr.outputs.pull-request-url }}). |
There was a problem hiding this comment.
I don't think it's necessary to remove this link.
| base: main | ||
| commit-message: 'feat: Node.js ${{ steps.updt.outputs.result }}' | ||
| title: 'feat: Node.js ${{ steps.updt.outputs.result }}' | ||
| body: 'Before commenting to ask when this will be available, see the [README](https://github.com/nodejs/docker-node#release-availability)' |
There was a problem hiding this comment.
I would have worded this a bit differently, but that's more of a style question.
"If you are reading this PR soon after it has been merged, you may find that new Docker images are missing or appear broken. Check back later and see the README for background information."
There was a problem hiding this comment.
Feel free to suggest the wording, I don't really feel strongly about the words I used
There was a problem hiding this comment.
I'd like to get back to this topic at a more general level in terms of how we can better inform users about progress and I'd like to involve the Docker team for this. Last week got quite hectic for lots of people in IT dealing with multiple security issues.
78941b5 to
83c88bc
Compare
MikeMcC399
left a comment
MikeMcC399
left a comment
There was a problem hiding this comment.
I'll go along with this change as it puts a bit more information into users' hands. There will probably still be users who are impatient and post comments though.
|
Created PR on the official-images repo (docker-library/official-images#22615). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub. |
Description
Adds the pointers/messages about the Docker Image release cycle to the body of the PRs.
Motivation and Context
Probably won't prevent the "why isn't this available" comments we often get, but having it in the body means it's less likely to ge folder/hidden if people come to the actual PRs to comment.
Testing Details
Example Output(if appropriate)
Types of changes
Checklist