You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
docs: clarify large MySQL migration examples - #22059
This PR fixes several inconsistencies in the large MySQL migration walkthroughs:
align the TiDB Lightning temporary disk-space guidance in migrate-large-mysql-to-tidb.md with the physical import mode documentation
clarify the non-GTID example in migrate-large-mysql-to-tidb.md so it uses the recorded binlog file and position, and explain when to switch to GTID mode instead
limit the DM examples in both large-migration guides to the same tables that Dumpling exports
clarify in migrate-large-mysql-shards-to-tidb.md that --checkpoint-error-destroy drops the failed target table and resets its checkpoint
make the large-shards guide use a consistent non-GTID example and explain when to switch to GTID mode
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
Chinese documentation has been updated based on English documentation changes.
ti-chi-botBot
added
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
and removed
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
labels
Nov 13, 2026
It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.
The documentation changes are mostly accurate and the default non-GTID path is sound. Users who switch to GTID mode could copy a placeholder GTID value, or not realize that an already-loaded source needs its enable-gtid setting updated. These documentation clarifications are worth making, but they should not block the merge.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
标题“docs: clarify large MySQL migration examples”与变更集的主要内容一致。变更涉及两份大规模 MySQL 迁移文档,包括 GTID 与 binlog 位置示例、DM 表范围示例,以及 --checkpoint-error-destroy 的说明。标题概括了主要变更,未涵盖所有细节,这属于正常范围。
Description check
描述基本完整。已填写“What is changed, added, or deleted?”一节,列出了五项具体修改。已勾选适用版本(master 与 v8.5),并给出相关 PR 和参考链接。已勾选 AI agent 参与选项。模板中的 First-time contributors' checklist 未勾选,但该项仅适用于首次贡献者,可以忽略。主要缺口是“What is changed”…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Description check
Explanation
描述基本完整。已填写“What is changed, added, or deleted?”一节,列出了五项具体修改。已勾选适用版本(master 与 v8.5),并给出相关 PR 和参考链接。已勾选 AI agent 参与选项。模板中的 First-time contributors' checklist 未勾选,但该项仅适用于首次贡献者,可以忽略。主要缺口是“What is changed”一节仅有 PR 内的简要说明,未解释每项修改的具体原因。
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Reviewing files that changed from the base of the PR and between a2cbb26 and 0dc7c2b.
Files selected for processing: 1
migrate-large-mysql-shards-to-tidb.md
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.
Reviewing files that changed from the base of the PR and between 66c2817 and a2cbb26.
Files selected for processing: 2
migrate-large-mysql-shards-to-tidb.md
migrate-large-mysql-to-tidb.md
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed, added, or deleted? (Required)
This PR fixes several inconsistencies in the large MySQL migration walkthroughs:
migrate-large-mysql-to-tidb.mdwith the physical import mode documentationmigrate-large-mysql-to-tidb.mdso it uses the recorded binlog file and position, and explain when to switch to GTID mode insteadmigrate-large-mysql-shards-to-tidb.mdthat--checkpoint-error-destroydrops the failed target table and resets its checkpointWhich TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit
--checkpoint-error-destroy会删除失败的目标表并重置其 checkpoint。