You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
docs: clarify large MySQL migration examples (#22059) - #22060
This PR fixes several inconsistencies in the large MySQL migration walkthroughs:
align the TiDB Lightning temporary disk-space guidance in migrate-large-mysql-to-tidb.md with the physical import mode documentation
clarify the non-GTID example in migrate-large-mysql-to-tidb.md so it uses the recorded binlog file and position, and explain when to switch to GTID mode instead
limit the DM examples in both large-migration guides to the same tables that Dumpling exports
clarify in migrate-large-mysql-shards-to-tidb.md that --checkpoint-error-destroy drops the failed target table and resets its checkpoint
make the large-shards guide use a consistent non-GTID example and explain when to switch to GTID mode
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
The default non-GTID walkthrough is consistent. Users who switch to GTID mode are not told how to update an already-registered data source or which GTID value to use. Fix these doc gaps before or shortly after merge.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
标题“docs: clarify large MySQL migration examples (#22059)”准确描述了主要变更:两份大型 MySQL 迁移指南的示例得到澄清。标题未覆盖 checkpoint 错误处理和 GTID 说明等全部细节,但这属于可接受范围。标题简洁,与变更集相符。
Description check
描述基本完整。已包含变更内容列表、适用版本选择(master 与 v8.5)、相关 PR 与参考链接,并标记了 AI 代理参与情况。变更内容与摘要和目标一致。不足之处:“What is changed”部分保留了模板注释占位符,文档中的 CLA 复选框未在模板中体现(模板包含该项但描述中已省略),且“Related code change PR links”字段为空。这些属于非关键项,不影响通过。
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Reviewing files that changed from the base of the PR and between 9294558 and 3e59786.
Files selected for processing: 2
migrate-large-mysql-shards-to-tidb.md
migrate-large-mysql-to-tidb.md
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #22059
What is changed, added, or deleted? (Required)
This PR fixes several inconsistencies in the large MySQL migration walkthroughs:
migrate-large-mysql-to-tidb.mdwith the physical import mode documentationmigrate-large-mysql-to-tidb.mdso it uses the recorded binlog file and position, and explain when to switch to GTID mode insteadmigrate-large-mysql-shards-to-tidb.mdthat--checkpoint-error-destroydrops the failed target table and resets its checkpointWhich TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit