Repository navigation
ci: complete maintenance workflow authorization - #22063
ti-chi-bot[bot] merged 1 commit into
Conversation
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the maintenance-workflow authorization changes.
No open issues 🎉
What changed in this PR
This PR extends the shared authorization checks introduced in #22058 to the remaining maintenance workflows.
Changes:
- Require current-attempt authorization before link scanning and issue creation, and support repository dispatches in the shared gate.
- Restrict the keywords workflow to
pingcap/docs-cnonmaster. - Expand regression coverage for dispatches, forks, branches/tags, revoked permissions, reruns, and link-issue authorization.
| File | Description |
|---|---|
scripts/test-privileged-workflow-actors.py |
Adds authorization cases, workflow-gate assertions, and a subprocess timeout. |
.github/workflows/link.yaml |
Gates link scanning and issue creation on current-attempt authorization. |
.github/workflows/keywords.yaml |
Adds the master branch restriction. |
.github/workflows/authorize-privileged-workflow.yml |
Applies requester permission checks to repository dispatches. |
Review effort: Balanced
[LGTM Timeline notifier]Timeline:
|
|
/approve |
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What is changed, added, or deleted? (Required)
Complete the remaining authorization checks for maintenance workflows:
pingcap/docs-cnmaster. Scheduled first attempts remain supported, and reruns must pass authorization for the current attempt.masterin addition to the existing repository check for the keywords workflow.flush-version.yamlandsync-doc-pr-en-to-zh.ymlalready use the shared repository, branch, account, permission, and rerun checks introduced in #22058, so their existing protections are retained.Validation: all eight existing security/default regression scripts passed (including the expanded authorization tests);
actionlint -shellcheck=passed for the shared gate and all four reported workflows;git diff --checkpassed. No production workflow was manually dispatched and no production secrets were used.Scope: these checks restrict execution of the reviewed workflows. They do not isolate repository-level secrets from a branch writer who can modify workflow definitions; that requires separate repository/environment secret controls.
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit
pingcap/docs-cn仓库的master分支运行。