Repository navigation
feat(spark): expose completed output writer summaries - #60
Merged
Merged
Conversation
Signed-off-by: Christopher Wirt <cwirt@quantcast.com>
Fold the Arrow buffer walk into one recursive helper, give VortexOutputWriterSummary value semantics, and drop redundant test assertions and helpers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Christopher Wirt <cwirt@quantcast.com>
a392n328
approved these changes
Nov 2, 2026
ChristopherWirt
added a commit
that referenced
this pull request
Nov 3, 2026
## Problem `VortexOutputWriter` has no way to set footer metadata, although `VortexWriter.Builder` supports it. Callers that write files outside Spark's commit protocol and need their own footer keys must keep a custom writer. The event store keeps `BoundedVortexFileWriter` for this reason alone, now that #60, #62 and #70 cover its batch limits and stats. ## Change - Add a `VortexOutputWriter` constructor that takes `Map<String, byte[]> metadata` and passes it to `VortexWriter.Builder.metadata`. - The existing constructor delegates with no metadata, so Spark's write path is unchanged. - Add `storesFooterMetadata`: writes a file with one metadata key, then reads both the key and the row back. ## Validation - `git diff --check` passes. - Gradle tests and spotless were not run locally; CI runs them. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Signed-off-by: Christopher Wirt <cwirt@quantcast.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #59.
Problem
VortexOutputWriter.close()throws away theVortexWriteSummarythatVortexWriter.finish()returns. To get a file's size or row count, a caller has to open the file again.Change
When
close()succeeds, the writer keeps an immutable, serializableVortexOutputWriterSummary, available fromsummary():fileSize()/rowCount()VortexWriter.finish()batchCount()peakBatchArrowBytes()peakBufferedBytes()bufferedBytes()value, sampled after each batchsummary()throwsIllegalStateException.Tests
VortexOutputWriterSummaryTestcovers:spark.kryo.unsafeboth on and off🤖 Generated with Claude Code