Repository navigation
feat(spark): let VortexOutputWriter store footer metadata - #77
Merged
Merged
Conversation
Adds a VortexOutputWriter constructor that takes footer metadata segments and passes them to the JNI writer builder, so callers writing files outside Spark's commit protocol can record their own metadata without a custom writer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Christopher Wirt <cwirt@quantcast.com>
a392n328
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
VortexOutputWriterhas no way to set footer metadata, althoughVortexWriter.Buildersupports it. Callers that write files outside Spark's commit protocol and need their own footer keys must keep a custom writer. The event store keepsBoundedVortexFileWriterfor this reason alone, now that #60, #62 and #70 cover its batch limits and stats.Change
VortexOutputWriterconstructor that takesMap<String, byte[]> metadataand passes it toVortexWriter.Builder.metadata.storesFooterMetadata: writes a file with one metadata key, then reads both the key and the row back.Validation
git diff --checkpasses.🤖 Generated with Claude Code