Skip to content

Open in... - #33

Merged
love-linger merged 3 commits into
sourcegit-org:masterfrom
ennerperez:feature/open_with
Mar 28, 2024
Merged

love-linger merged 3 commits into
sourcegit-org:masterfrom
ennerperez:feature/open_with

Conversation

@ennerperez

Copy link
Copy Markdown
Contributor

Contextual menu to "Open with actions..."

image

  • Open in Fleet
  • Open in Visual Studio Code

@love-linger

Copy link
Copy Markdown
Collaborator

I've tested your PR. The functionality is complete.

But using the Avalonia.Svg increase the size for final exe from 37MB to 42MB! Then I converts these two SVG icon to PNG image with 64x64 size and removed reference for Avalonia.SVG. After that the size of
final exe comes back to 37MB.

So, I suggest use PNG instead of SVG for this PR.

love-linger added a commit that referenced this pull request Mar 28, 2024
* use PNG instead of SVG for external tool icons and remove dependency `Avalonia.SVG`
* remove unused property `IsVSCodeFound` and `IsFleetFound`
* find VS from registry first
* remove compile warning CA1416
* remove unused enum `OS.Platforms`
love-linger added a commit that referenced this pull request Mar 28, 2024
@love-linger
love-linger merged commit 370b9bd into sourcegit-org:master Mar 28, 2024
@ennerperez

Copy link
Copy Markdown
Contributor Author

There is a file size limit for the final exe? I think the usage of Avalonia.Svg worth it. specially to improve the UI, add new icons, and make it scalable for different resolutions, I have to test it in high DPI resolution when probably PNG quality is not good enough.

@love-linger

Copy link
Copy Markdown
Collaborator

There is a file size limit for the final exe? I think the usage of Avalonia.Svg worth it. specially to improve the UI, add new icons, and make it scalable for different resolutions, I have to test it in high DPI resolution when probably PNG quality is not good enough.

No, there's no limitations for the size of final exe. But in this project, SVG only used to display the external editor icons. I think it's not worth to introduce a new package since we can use RenderOptions.BitmapInterpolationMode="HighQuality" to get a similar result with built-in PNG support.

@ennerperez

Copy link
Copy Markdown
Contributor Author

What happened with the menu?

@love-linger

Copy link
Copy Markdown
Collaborator

Now, only external tools detected by the software are displayed.

1llum1n4t1s pushed a commit to 1llum1n4t1s/Komorebi that referenced this pull request May 16, 2026
…O(n²) (P1#25/27/30)

/rere 10 人分隊レビュー P1 バッチ 9: 独立修正可能な 3 件を実施。設計判断系
(#18/sourcegit-org#23/sourcegit-org#33) は別 PR/別セッションへ deferred。

【sourcegit-org#30】AvatarManager._resources の無制限増殖を防止
- ConcurrentQueue<string> _resourceInsertionOrder で挿入順を保持
- 1024 件超過時に EvictionBatchSize(256) 件を FIFO で削除
- デフォルトアバター (GitHub/Unreal) はエビクション対象外
- 既存の 3 つの追加点 (Request/SetFromLocal/Download完了) を InsertCachedAvatar に統一

【sourcegit-org#25】HistoryFilter.Pattern の長さ制限 (DoS 防御)
- SanitizePattern に MaxPatternLength=1024 のクランプを追加
- LINQ Where による文字フィルタ前に切り詰めて O(n) を保証
- Git ref 名は仕様上 255 byte 程度が現実的なので通常利用への影響なし

【sourcegit-org#27】Anthropic tool_use ループの O(n²) DeepClone を排除
- JsonObject.Remove("messages")/Remove("tools") で attach/detach パターンに変更
- messages 配列が伸びるたびに毎回 DeepClone していた CPU/メモリコストを削減
- ToJsonString による serialize 1 回 + Remove 2 回で済む

#20 (Velopack rollback 手順) は TROUBLESHOOTING.md シナリオ C に既存記載があるためスキップ。
sourcegit-org#34 (Preferences .bak) は既に実装済み (Save/Load 双方に backup 経路あり)。

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants