Skip to content

Enhance file and folder selection - #34

Merged
love-linger merged 1 commit into
sourcegit-org:masterfrom
walterlv:master
Mar 28, 2024
Merged

love-linger merged 1 commit into
sourcegit-org:masterfrom
walterlv:master

Conversation

@walterlv

Copy link
Copy Markdown
Contributor

Enhance file and folder selection by utilizing the default file manager instead of enforcing the use of explorer.exe.

Before this PR:

  • file and folder selection was enforced to use explorer.exe.

After this PR:

  • file and folder selection will use the default file manager.

Note:

I'm using Directory Opus as my default file manager, so I will be very happy if this PR is merged.

…er instead of enforcing the use of explorer.exe
@love-linger

Copy link
Copy Markdown
Collaborator

Thanks for the nice PR!

@love-linger
love-linger merged commit 8ed068e into sourcegit-org:master Mar 28, 2024
1llum1n4t1s pushed a commit to 1llum1n4t1s/Komorebi that referenced this pull request May 16, 2026
…O(n²) (P1#25/27/30)

/rere 10 人分隊レビュー P1 バッチ 9: 独立修正可能な 3 件を実施。設計判断系
(#18/sourcegit-org#23/sourcegit-org#33) は別 PR/別セッションへ deferred。

【sourcegit-org#30】AvatarManager._resources の無制限増殖を防止
- ConcurrentQueue<string> _resourceInsertionOrder で挿入順を保持
- 1024 件超過時に EvictionBatchSize(256) 件を FIFO で削除
- デフォルトアバター (GitHub/Unreal) はエビクション対象外
- 既存の 3 つの追加点 (Request/SetFromLocal/Download完了) を InsertCachedAvatar に統一

【sourcegit-org#25】HistoryFilter.Pattern の長さ制限 (DoS 防御)
- SanitizePattern に MaxPatternLength=1024 のクランプを追加
- LINQ Where による文字フィルタ前に切り詰めて O(n) を保証
- Git ref 名は仕様上 255 byte 程度が現実的なので通常利用への影響なし

【sourcegit-org#27】Anthropic tool_use ループの O(n²) DeepClone を排除
- JsonObject.Remove("messages")/Remove("tools") で attach/detach パターンに変更
- messages 配列が伸びるたびに毎回 DeepClone していた CPU/メモリコストを削減
- ToJsonString による serialize 1 回 + Remove 2 回で済む

#20 (Velopack rollback 手順) は TROUBLESHOOTING.md シナリオ C に既存記載があるためスキップ。
sourcegit-org#34 (Preferences .bak) は既に実装済み (Save/Load 双方に backup 経路あり)。

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants