Repository navigation
[CMake 4/7] Make probability test fixtures safe for grouped linking - #3504
Open
SteveBronder wants to merge 1 commit into
Open
SteveBronder wants to merge 1 commit into
SteveBronder wants to merge 1 commit into
Conversation
This was referenced Nov 3, 2026
WardBrian
previously approved these changes
Nov 3, 2026
SteveBronder
enabled stacked auto-merge
November 4, 2026 16:15
stacked auto-merge was automatically disabled
November 4, 2026 16:44
Auto-merge was disabled for another pull request in the stack
SteveBronder
changed the title
3 of 5 tasks
SteveBronder
force-pushed
the
cmake-split/04-probability-tests
branch
from
November 5, 2026 14:39
320f21c to
9bac38c
Compare
WardBrian
force-pushed
the
cmake-split/04-probability-tests
branch
from
November 6, 2026 10:47
9bac38c to
f9899e0
Compare
Inline shared probability-test helpers and distinguish colliding fixture types. Move ordinary GoogleTests out of generated fixture headers into unit sources, preserving their assertions and avoiding duplicate tests.
WardBrian
force-pushed
the
cmake-split/04-probability-tests
branch
from
November 6, 2026 20:06
f9899e0 to
8c2c013
Compare
WardBrian
approved these changes
Nov 6, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Generated probability sources include fixture headers in multiple translation units. Inline header-defined helpers, distinguish four colliding fixture class names, and move ordinary GoogleTests from fixture headers into their unit-test sources. All 12 moved test blocks retain their original contents.
Part 4 of the CMake migration split from #3463.
Targets
cmake-split/03-tbb-isolation(#3503) as the preceding layer of the native stack. The review contains only this layer's prepared patch and its supporting tests.Tests
Side Effects
Test fixture names change to avoid collisions, and ordinary tests run once in their unit sources instead of being repeated in generated probability sources.
Release notes
Prepare generated probability fixtures for grouped linking without duplicating ordinary tests.
Checklist
Related PRs
Native stack: https://github.com/stan-dev/math/stack/3509