Repository navigation
[CMake 5/7] Make unit tests safe for grouped execution - #3505
Open
SteveBronder wants to merge 1 commit into
Open
SteveBronder wants to merge 1 commit into
SteveBronder wants to merge 1 commit into
Conversation
This was referenced Nov 3, 2026
WardBrian
previously approved these changes
Nov 3, 2026
SteveBronder
enabled stacked auto-merge
November 4, 2026 16:15
SteveBronder
disabled stacked auto-merge
November 4, 2026 16:44
SteveBronder
changed the title
3 of 5 tasks
SteveBronder
force-pushed
the
cmake-split/05-unit-tests
branch
from
November 5, 2026 14:39
50272f8 to
9dd379e
Compare
WardBrian
force-pushed
the
cmake-split/05-unit-tests
branch
from
November 6, 2026 10:47
9dd379e to
1077b99
Compare
Inline shared test helpers, distinguish MPI call IDs and fixtures, and clean up autodiff state between grouped OpenCL tests. Guarantee the Bernoulli GLM invalid-label fixture contains an invalid label.
WardBrian
force-pushed
the
cmake-split/05-unit-tests
branch
from
November 6, 2026 20:06
1077b99 to
09896e8
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Grouped unit executables expose duplicate helper definitions, conflicting MPI registrations, and autodiff state left behind by earlier tests. Inline shared helpers, give MPI fixtures and call IDs distinct names, and use the autodiff cleanup fixture for the affected OpenCL tests. Guarantee that the Bernoulli GLM invalid-label fixture contains an invalid label.
Part 5 of the CMake migration split from #3463.
Targets
cmake-split/04-probability-tests(#3504) as the preceding layer of the native stack. The review contains only this layer's prepared patch and its supporting tests.Tests
Side Effects
Test fixtures, registration IDs, and cleanup behavior change. Production Math code is unaffected.
Release notes
Make unit tests safe to link and execute in shared test processes.
Checklist
Related PRs
Native stack: https://github.com/stan-dev/math/stack/3509