Repository navigation
fix: replace Slashtags with Pubky in terms of use - #1936
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Triage: this PR goes in the 3.2.0 milestone under #1938, with #1933 stacked on it; that one closes the issue once it targets master. Twin: synonymdev/bitkit-ios#1345. |
[Medium impact] The PR appears safe to merge. SummaryReplaces Slashtags with Pubky and Paykit in the in-app terms.
No actionable issues found. Device tests were not run. Reviews (1) · Last reviewed commit: "chore: add changelog fragment" · Reviewed by Greptile |
Regtest APKDownload bitkit-dev-debug universal APK (expires in 30 days). |
talosmachina
left a comment
There was a problem hiding this comment.
No findings. Replaces Slashtags with Pubky and Paykit in the in-app Terms of Use (section 6, definitions 2.1.5/2.1.33/2.1.39, 7.1.1) and moves the effective date to November 27, 2026. Reviewed 197244b, full tier, root of the stack under #1933.
What I checked, and 4 candidates I ruled out
Read in full: TOS.kt at the head, journeys/terms-of-use.xml, the changelog fragment
CI: green (build-and-test, compose-ui, detekt, e2e-tests-local shards, Greptile)
Build: not run here; on the Bitkit Android track the branch is reviewed from the code and CI, which built and tested it
Ruled out
- Definition numbering: the 54
2.1.xentries run 1 to 54 with no gap or duplicate after inserting Paykit (2.1.33) and Pubky (2.1.39) and dropping Slashtags; alphabetical order holds. - Stale cross-references: no clause refers to a definition by number, and the remaining section references (9, 10.2, 14.1, 20) are unaffected by the change; no
Slashtagsis left inTOS.kt. - Journey drift: USDT really is 2.1.50 now, and the section 6 heading matches the new step word for word.
- Twin parity: the 2.1.5/2.1.33/2.1.39 and 6.1 to 6.4 text matches
Tos.swifton synonymdev/bitkit-ios word for word, and so does the effective date.
Merge confidence: 5/5, CI green, files read whole, and the change is legal copy, which no unit test applies to (the journey covers the heading and date).
Reviewer model: claude-opus-5-5
Reasoning effort: Not exposed (the run metadata does not record it)
There was a problem hiding this comment.
Verdict: ✅ Approve
Findings: None.
QA for 197244b:
Onboarding terms and Continue ✅ The new date, USDT definition and Pubky heading render correctly, the journey's bold spans and final clause remain readable, and Continue opens the welcome screen.
Drove journeys/terms-of-use.xml on a fresh English Android 16 install using an assembleDevDebug build of this head. Both welcome controls are visible; SkipIntro was checked visually because its tag is omitted from the UI dump, and the tag is present in source.
Recordings follow the journey in order, at 2× speed.
| Date and definitions | Warnings and Pubky heading | Final clauses and Continue |
|---|---|---|
terms-start2x.2x.mp4 |
terms-middle2x.small.mp4 |
terms-end2x.2x.mp4 |
Check: terms numbering and twin parity ✅ Source comparison confirms consecutive definitions, removal of Slashtags and matching replacement wording.
Definitions run from 2.1.1 through 2.1.54 without gaps or duplicates. The changed prose matches synonym-website#266 fix: replace Slashtags with Pubky in Bitkit terms. Journey XML parsing and git diff --check pass.
No planned cases remain unrun. Full review of abf4665..197244b, covering all three changed files and the onboarding rendering path; changelog and full copy parity were checked in source.
Twin: bitkit-ios#1345 fix: replace Slashtags with Pubky in terms of use at d328bec matches the changed wording, date and journey.
Reviewed by gpt-6.1-sol-high
ben-kaufman
left a comment
There was a problem hiding this comment.
No material findings in the terminology and terms changes at 197244b. This review did not verify device rendering or run journeys/terms-of-use.xml. The public-payment wording in #1933 is outside this approval.
Reviewer model: gpt-6.1-sol
Reasoning effort: xhigh
|
Merged, as it was approved and green. |
Description
Replaces Slashtags with Pubky in the in-app Terms of Use, mirroring the same change on bitkit.to (synonymdev/synonym-website, see the linked PR there). Bitkit no longer uses Slashtags.
journeys/terms-of-use.xml: checks the new date, the USDT definition at 2.1.50, and the Section 6 heading.The clauses about public payments (6.5–6.5.5) are in #1933, stacked on this PR, so they can be reviewed on their own.
Twin: synonymdev/bitkit-ios#1345
Out of Scope
QA Notes
journeys/terms-of-use.xml.🤖 Generated with Claude Code