Repository navigation
Conversation
Regtest APKDownload bitkit-dev-debug universal APK (expires in 30 days). |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
57a6fb4 to
e24e5a5
Compare
|
Triage: #1938 tracks this PR in the 3.2.0 milestone, with the contact payments change it covers (#1932). Twin: synonymdev/bitkit-ios#1342 (synonymdev/bitkit-ios#1347). |
[Low impact] The PR appears safe to merge; no actionable issues remain. SummaryAdds public-payment terms covering automatic publishing, public visibility, profile removal, homeservers, and recipient checks.
Reviews (3) · Last reviewed commit: "fix: name disconnecting as a way to stop..." · Reviewed by Greptile |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
talosmachina
left a comment
There was a problem hiding this comment.
No findings. Adds Terms of Use clauses 6.5 to 6.5.5 (public payments through Paykit) to the onboarding TOS screen, plus a changelog fragment and a journey step for 6.5.1. Reviewed d170e23, light tier (text-only, 15 added lines), stacked on #1936.
What I checked, and 3 candidates I ruled out
Read in full: TOS.kt at the head, the journeys/terms-of-use.xml hunk, the changelog fragment.
Parity: the six clauses are word for word the same as the iOS twin synonymdev/bitkit-ios#1342.
CI: lint and detekt pass. The red build check is the gate job of a run whose build and Compose UI jobs were cancelled (BUILD_RESULT: cancelled, COMPOSE_RESULT: cancelled), not a failure; the newer build-and-test and compose-ui runs were still pending when I looked. Not built here: a text-only change in a Kotlin raw string, CI is the gate.
Ruled out
- Defined terms: "Paykit" (2.1.33) and "Pubky" (2.1.39) are defined in the base PR; "Third-Party Service" in 6.5.4 matches the spelling Section 9 already uses throughout (the 2.1.49 definition spells it without the hyphen, which predates this PR).
- Cross-reference: "Section 9" is "9. THIRD PARTY SERVICES" in the same file.
- Journey order: the new 6.5.1 step sits between the section 6 heading and section 7.2, matching the scroll direction.
Merge confidence: 4/5, the change is copy, but CI has not finished a green run on this head yet.
There was a problem hiding this comment.
Verdict: ✅ Approve
Findings: None.
QA for d170e23:
Read the onboarding terms and continue ✅ The terms render through the final clause, and Continue opens the welcome screen without a checkbox.
J1, fresh English install, Android 16 / API 36, dev debug build from this head. Checked the November 27 date, required bold definitions and warnings, Section 6, clause 6.5.1, jury-trial waiver and final acceptance paragraph. Both welcome buttons are visible. GetStarted appears in the UI dump; the CLI omits SkipIntro, whose tag was confirmed in IntroScreen.kt.
J1-2x.small.mp4
Terms journey, 2× speed.
Read the public-payment clauses ✅ The Paykit and Pubky definitions and Section 6 through 6.5.5 render on a fresh installation.
Manual test 1. Read the public-payment wording, including disconnecting, public visibility, endpoint removal, homeservers and recipient checks. Source comparison confirms all six new clauses match the website and iOS twin exactly, and no Slashtags wording remains in TOS.kt.
manual1-2x.small.mp4
Definitions and public-payment clauses, 2× speed.
Check: wording and cross-platform parity ✅ The six clauses match, and the existing homeserver wording correction holds.
Checked the corrected homeserver clause, the Section 9 reference and the terms rendering path. The complete journey action sequence matches iOS. assembleDevDebug and git diff --check passed. Unit and lint suites were not rerun locally; build and tests and lint are green.
Twin: synonymdev/bitkit-ios#1342 fix: add public payment terms at 94efdb4 matches word for word. Its recorded terms QA covers the iOS flow.
Website: synonymdev/synonym-website#265 fix: add public payment terms to Bitkit terms at 8cd42b6 matches all six new clauses.
Coverage: full three-file diff 197244b..d170e23. No planned device cases remain unrun. Device QA covers the terms and acceptance flow; payment publishing and profile removal were not exercised by this text-only change.
Reviewed by gpt-6.1-sol-high
Closes #1938
Description
Adds the Terms of Use clauses for public payments. Bitkit makes private and public contact payments always on while a Pubky profile exists, with no toggle; deleting the profile stops them (Slack). App changes: synonymdev/bitkit-ios#1338, #1932.
Stacked on #1936, which replaces Slashtags with Pubky, adds the definitions and sets the effective date. This PR only adds clauses 6.5–6.5.5 and the journey check of 6.5.1. Mirrors synonymdev/synonym-website#265.
New clause 6.5 and its sub-clauses:
Private contact payments get no new clause: JC confirmed the current Terms and Privacy Policy already cover them being on by default (Slack). JC should confirm that also covers payments having no off switch.
Twin: synonymdev/bitkit-ios#1342
Design
N/A — text-only change to an existing screen.
Preview
N/A
QA Notes
Setup
N/A — text-only change.
Journeys
terms-of-use.xml— the USDT definition is now checked at 2.1.50 (was 2.1.49), and a new step checks the "6. PUBKY AND CONTACT PAYMENTS" heading and clause 6.5.1; same step sequence as the iOS twinManual Tests
Automated Checks
compileDevDebugKotlinanddetekt— passEvidence
Compile and detekt passed on this branch. The terms text was compared against the website PR's diff.
Gaps
J1 and manual test 1 not run on a device.
Models used
Claude Opus 5.5(reasoning: Not exposed)Claude Opus 5.5(reasoning: Not exposed)🤖 Generated with Claude Code