Repository navigation
Conversation
Queue a one-time change at upgrade for wallets with a stored Pubky identity, and run it in the background once the wallet, node and session are ready. It goes through the Settings enable paths for private and public payments, skips settings the user already chose, drops the private step for profiles without private access, and keeps transient failures queued for the next launch. The public toggle now records the user's choice. Sign-out, profile deletion and wallet reset clear the queue. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 16, 2026
Member
Author
|
Closing as superseded by #1338. Contact payments are now always on while a Pubky profile exists, and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #1338. That PR removes both payment toggles and turns private and public payments on at every launch for any profile that has them off, which covers existing profiles. This PR will be closed once it merges.
This PR turns private and public payments on once for Pubky profiles that existed before payments were on by default.
Context: https://synonymworkspace.slack.com/archives/C07BJ7DNPCG/p1794640038822989. John does not want users to opt in to private or public payments. The new-profile defaults and the Pay Contacts removal are a separate PR; this one covers profiles that already exist and does not depend on it.
Do not merge before the public payments Terms update (synonymdev/synonym-website#265, #1342) is approved. This turns on public payment endpoints for users who never chose them. JC confirmed the current Terms already cover private payments on by default (Slack).
Description
Enabling private payments here runs the v0.1 per-contact private endpoint setup for every saved contact of every existing user on update. That is the slow path Paykit v0.2 replaces, and it runs for everyone after the update ships.
Out of Scope
Bitkit/Utilities/AppDataMigrations.swift: public opt-outs made before this update. Migration 4 turned public payments off for every wallet, and the toggle stored no choice until this PR, so a user who turned public payments off after migration 4 cannot be told apart from one who never touched it. Both get public payments on.Twin: synonymdev/bitkit-android#1931
Design
N/A — no UI changes.
Preview
N/A — no user-visible UI change; settings toggles flip on in the background.
QA Notes
Setup
journeys/payment-requests/README.md.Journeys
N/A — not drivable; see Manual Tests.
Manual Tests
Automated Checks
PaykitPaymentsMigrationTests.swift— queues only for wallets with a profile and only once; skips payments already on, private opt-outs and public choices; enables both and clears the queue; drops private without access and still enables public; keeps transient failures and superseded steps queued; attempts once per launch; does not start or count while not current; stops before public when the session ends; keeps a public choice made during the private stepContactPaymentsServiceTests.swift— the public toggle records a choice; the migration's enable does notAppDataMigrationsTests.swift— schema version 5Evidence
PaykitPaymentsMigrationTests(16),ContactPaymentsServiceTests(37) andAppDataMigrationsTests(10) pass.swiftformat --lintpasses on the changed files.Gaps
Models used
claude-opus-5-5(reasoning: Not exposed)claude-opus-5-5(reasoning: Not exposed)Metadata note: the session reports the model ID; the reasoning setting is not exposed in the session metadata.
🤖 Generated with Claude Code