Skip to content

fix: add public payment terms - #1342

Open
jvsena42 wants to merge 6 commits into
masterfrom
fix/tos-pubky-contact-payments
Open

jvsena42 wants to merge 6 commits into
masterfrom
fix/tos-pubky-contact-payments

Conversation

@jvsena42

@jvsena42 jvsena42 commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

Closes #1347

Description

Adds the Terms of Use clauses for public payments. Bitkit makes private and public contact payments always on while a Pubky profile exists, with no toggle; deleting the profile stops them (Slack). App changes: #1338, synonymdev/bitkit-android#1932.

Stacked on #1345, which replaces Slashtags with Pubky, adds the definitions and sets the effective date. This PR only adds clauses 6.5–6.5.5 and the journey check of 6.5.1. Mirrors synonymdev/synonym-website#265.

New clause 6.5 and its sub-clauses:

  • 6.5: creating or connecting a Pubky profile lets you receive payments through Paykit, and you agree to the clauses below.
  • 6.5.1: public payments are turned on when you create or connect a profile, an app update may turn them on for an existing profile, they stay on while you have a profile, and deleting or disconnecting it stops them.
  • 6.5.2: what public payments publish (payment details on your homeserver, readable by anyone who knows your Pubky) and that on-chain payments to them can be linked to your Pubky.
  • 6.5.3: deleting or disconnecting the profile stops new publishing and removes published details where the homeserver allows; copies others already read can't be recalled.
  • 6.5.4: the profile and payment details live on the homeserver that hosts your Pubky; a third-party homeserver is a Third-Party Service under Section 9.
  • 6.5.5: Synonym doesn't verify the identity behind a Pubky or its payment details.

Private contact payments get no new clause: JC confirmed the current Terms and Privacy Policy already cover them being on by default (Slack). JC should confirm that also covers payments having no off switch.

Twin: synonymdev/bitkit-android#1933

QA Notes

  • Simulator build (arm64, Debug): succeeded.
  • swiftformat --lint on Tos.swift: passes.
  • Changelog fragment: changelog.d/next/1342.changed.md.
  • Journey terms-of-use.xml not run on a device.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jvsena42 and others added 2 commits November 16, 2026 11:02
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@jvsena42
jvsena42 force-pushed the fix/tos-pubky-contact-payments branch from 67bf2f8 to fc58f4d Compare November 16, 2026 14:02
@jvsena42
jvsena42 changed the base branch from master to fix/tos-replace-slashtags November 16, 2026 14:02
@jvsena42 jvsena42 changed the title fix: cover Pubky contact payments in terms of use fix: add public payment terms Nov 16, 2026
@talosmachina
talosmachina self-requested a review November 16, 2026 14:04
@ovitrif

ovitrif commented Nov 16, 2026

Copy link
Copy Markdown
Collaborator

Triage: #1347 tracks this PR in the 3.2.0 milestone, with the contact payments change it covers (#1338). Twin: synonymdev/bitkit-android#1933 (synonymdev/bitkit-android#1938).

@jvsena42
jvsena42 marked this pull request as ready for review November 16, 2026 14:08
@jvsena42
jvsena42 requested review from a team, ben-kaufman and ovitrif and removed request for a team November 16, 2026 14:08
@greptile-apps

greptile-apps Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge; no actionable issues remain in the reviewed changes.

Summary

Adds public-payment terms covering automatic publishing, public visibility, profile removal, homeservers, and recipient checks.

  • Pubky profiles keep public payments on and explain what that means.

Reviews (3) · Last reviewed commit: "fix: name disconnecting as a way to stop..." · Reviewed by Greptile

Comment thread journeys/terms-of-use.xml Resolved
@jvsena42
jvsena42 marked this pull request as draft November 16, 2026 14:21
jvsena42 and others added 2 commits November 16, 2026 11:25
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@talosmachina talosmachina left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 finding (1 P2). Adds clauses 6.5 to 6.5.5 on public payments to the in-app Terms of Use. Reviewed 92239a1, full tier; the PR is still a draft, reviewed because the author asked.

What I checked, and 4 candidates I ruled out

Read in full: the Tos.swift diff and section 6 around it, journeys/terms-of-use.xml, changelog.d/next/1342.changed.md
Checked against the app: the removal paths on #1338's head and on master (EditProfileView.swift, PubkyProfileManager.swift, PubkyAppProfileStore.deleteProfile), to see which user actions stop publishing
Compared: 6.5 to 6.5.5 against the twin, synonymdev/bitkit-android#1933 (TOS.kt): word for word the same
CI: SwiftFormat green; the build and test jobs skip on this stacked base

Ruled out

  • 6.5.2 overstates what is published: the public method ids are on-chain addresses, BOLT11 and a USDT Arbitrum address, so "such as a Bitcoin address and a Lightning invoice" is accurate as an example list.
  • 6.5.3 overstates removal: sign-out and profile deletion both call removePublicPaykitEndpointsBestEffort, which sets a cleanup-pending flag when the homeserver write fails, so "where the homeserver allows it" is the right hedge.
  • Section 9 reference: 6.5.4 points at Section 9, which is THIRD PARTY SERVICES; the hyphenated "Third-Party Service" spelling already appears in 9.1.
  • Journey drift: the 6.5.1 step matches the Android journey file line for line.

Merge confidence: 4/5, one P2 on the wording of the off switch.

Reviewer model: claude-opus-5-5
Reasoning effort: Not exposed

Comment thread Bitkit/Views/Onboarding/Tos.swift Resolved
@jvsena42
jvsena42 marked this pull request as ready for review November 16, 2026 14:53
@jvsena42
jvsena42 marked this pull request as draft November 16, 2026 14:57
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@jvsena42
jvsena42 marked this pull request as ready for review November 16, 2026 15:03
@ovitrif
ovitrif changed the base branch from fix/tos-replace-slashtags to master November 16, 2026 15:41
@ovitrif

ovitrif commented Nov 16, 2026

Copy link
Copy Markdown
Collaborator

Retargeted to master, since #1345 below it is merging.

github-actions Bot added a commit that referenced this pull request Nov 16, 2026
{"kind":"bitkit-retarget-execution-v1","repository":"synonymdev/bitkit-ios","pr":1342,"generation":"43899081228-1","sourceSha":"3721cf86b6c30d9c4a0d80709b0c2b1b0e508ff0","sourceRef":"master","owner":"github-actions[bot]"}

@ovi-reviewer ovi-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: ✅ Approve

Findings: None.

QA for 94efdb4:

Read the onboarding terms and continue ✅ The full terms journey passed on a fresh English installation, including Section 6 and Continue to the welcome screen.

J1, iPhone 17 Pro, iOS 27.0, Debug build from this head. Checked the November 27 date, bold definitions and warnings, Section 6 heading, clauses 6.5–6.5.5, the jury-trial waiver and the final clause. Continue worked without a checkbox and opened both GetStarted and SkipIntro.

J1-2x.small.mp4

Full terms journey, 2× speed.

Check: public-payment wording and removal paths ✅ Source comparison confirms matching clauses and both earlier fixes.

Compared all six new clauses with the Android twin and website. Checked profile removal and PubkyProfileManager.signOut, including best-effort public endpoint cleanup. SwiftFormat 0.64.6 lint and git diff --check passed.

Twin: bitkit-android#1933 fix: add public payment terms at d170e2324 matches word for word.

Website: synonym-website#265 fix: add public payment terms to Bitkit terms at 8cd42b6 also matches.

Coverage: full four-file PR diff at 94efdb4. No planned cases remain unrun. Payment publishing and removal behavior were checked in code; device QA covered the terms and acceptance flow.


Reviewed by gpt-6.1-sol-high

@ovitrif ovitrif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@jvsena42
jvsena42 enabled auto-merge November 17, 2026 14:29
@jvsena42
jvsena42 disabled auto-merge November 17, 2026 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: terms of use cover contact payments

3 participants