Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
67bf2f8 to
fc58f4d
Compare
|
Triage: #1347 tracks this PR in the 3.2.0 milestone, with the contact payments change it covers (#1338). Twin: synonymdev/bitkit-android#1933 (synonymdev/bitkit-android#1938). |
[Low impact] The PR appears safe to merge; no actionable issues remain in the reviewed changes. SummaryAdds public-payment terms covering automatic publishing, public visibility, profile removal, homeservers, and recipient checks.
Reviews (3) · Last reviewed commit: "fix: name disconnecting as a way to stop..." · Reviewed by Greptile |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
talosmachina
left a comment
There was a problem hiding this comment.
1 finding (1 P2). Adds clauses 6.5 to 6.5.5 on public payments to the in-app Terms of Use. Reviewed 92239a1, full tier; the PR is still a draft, reviewed because the author asked.
What I checked, and 4 candidates I ruled out
Read in full: the Tos.swift diff and section 6 around it, journeys/terms-of-use.xml, changelog.d/next/1342.changed.md
Checked against the app: the removal paths on #1338's head and on master (EditProfileView.swift, PubkyProfileManager.swift, PubkyAppProfileStore.deleteProfile), to see which user actions stop publishing
Compared: 6.5 to 6.5.5 against the twin, synonymdev/bitkit-android#1933 (TOS.kt): word for word the same
CI: SwiftFormat green; the build and test jobs skip on this stacked base
Ruled out
- 6.5.2 overstates what is published: the public method ids are on-chain addresses, BOLT11 and a USDT Arbitrum address, so "such as a Bitcoin address and a Lightning invoice" is accurate as an example list.
- 6.5.3 overstates removal: sign-out and profile deletion both call
removePublicPaykitEndpointsBestEffort, which sets a cleanup-pending flag when the homeserver write fails, so "where the homeserver allows it" is the right hedge. - Section 9 reference: 6.5.4 points at Section 9, which is THIRD PARTY SERVICES; the hyphenated "Third-Party Service" spelling already appears in 9.1.
- Journey drift: the 6.5.1 step matches the Android journey file line for line.
Merge confidence: 4/5, one P2 on the wording of the off switch.
Reviewer model: claude-opus-5-5
Reasoning effort: Not exposed
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Retargeted to master, since #1345 below it is merging. |
{"kind":"bitkit-retarget-execution-v1","repository":"synonymdev/bitkit-ios","pr":1342,"generation":"43899081228-1","sourceSha":"3721cf86b6c30d9c4a0d80709b0c2b1b0e508ff0","sourceRef":"master","owner":"github-actions[bot]"}
There was a problem hiding this comment.
Verdict: ✅ Approve
Findings: None.
QA for 94efdb4:
Read the onboarding terms and continue ✅ The full terms journey passed on a fresh English installation, including Section 6 and Continue to the welcome screen.
J1, iPhone 17 Pro, iOS 27.0, Debug build from this head. Checked the November 27 date, bold definitions and warnings, Section 6 heading, clauses 6.5–6.5.5, the jury-trial waiver and the final clause. Continue worked without a checkbox and opened both GetStarted and SkipIntro.
J1-2x.small.mp4
Full terms journey, 2× speed.
Check: public-payment wording and removal paths ✅ Source comparison confirms matching clauses and both earlier fixes.
Compared all six new clauses with the Android twin and website. Checked profile removal and PubkyProfileManager.signOut, including best-effort public endpoint cleanup. SwiftFormat 0.64.6 lint and git diff --check passed.
- Confirmed the disconnect wording correction in 6.5.1 and 6.5.3.
- Confirmed the journey scroll correction in the XML and drove the heading and clause checks separately.
Twin: bitkit-android#1933 fix: add public payment terms at d170e2324 matches word for word.
Website: synonym-website#265 fix: add public payment terms to Bitkit terms at 8cd42b6 also matches.
Coverage: full four-file PR diff at 94efdb4. No planned cases remain unrun. Payment publishing and removal behavior were checked in code; device QA covered the terms and acceptance flow.
Reviewed by gpt-6.1-sol-high
Closes #1347
Description
Adds the Terms of Use clauses for public payments. Bitkit makes private and public contact payments always on while a Pubky profile exists, with no toggle; deleting the profile stops them (Slack). App changes: #1338, synonymdev/bitkit-android#1932.
Stacked on #1345, which replaces Slashtags with Pubky, adds the definitions and sets the effective date. This PR only adds clauses 6.5–6.5.5 and the journey check of 6.5.1. Mirrors synonymdev/synonym-website#265.
New clause 6.5 and its sub-clauses:
Private contact payments get no new clause: JC confirmed the current Terms and Privacy Policy already cover them being on by default (Slack). JC should confirm that also covers payments having no off switch.
Twin: synonymdev/bitkit-android#1933
QA Notes
swiftformat --lintonTos.swift: passes.changelog.d/next/1342.changed.md.terms-of-use.xmlnot run on a device.🤖 Generated with Claude Code