Repository navigation
Conversation
… helpers - Flattens _handleMergeGroup cognitive complexity from 16 to <= 8 using pattern matching and extracted helper methods. - Extracts _handleCheckRun from post to drop post complexity below 10. - Extracts runWithPrLock from PullRequestManager._runWithLock to allow locking by slug and PR number directly. - Extracts _evaluateCheckRuns in PushGoldStatusToGithub using a Dart record return type to prepare for check run filtering.
There was a problem hiding this comment.
Code Review
This pull request refactors several request handlers and services by extracting helper methods to improve code modularity and readability. Specifically, it extracts check run and merge group handlers in webhook_subscription.dart, check run evaluation in push_gold_status_to_github.dart, and a PR locking mechanism in pull_request_manager.dart. The review feedback points out potential runtime errors in the extracted _evaluateCheckRuns method, specifically warning against unsafe nested JSON parsing of checkSuites and a potential null pointer exception when accessing checkRun['name'].
This was referenced Nov 10, 2026
jtmcdole
marked this pull request as ready for review
November 10, 2026 19:30
zanderso
approved these changes
Nov 13, 2026
zanderso
left a comment
Member
There was a problem hiding this comment.
lgtm - pure refactor with no semantic change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits
_handleMergeGroupinto smaller action handlers to lower cognitive complexity before addingWANT_LGTMmerge-group waivers. Also extracts shared check-run lookup helpers inGithubService.WANT_LGTMStack (RFC 610.0001)Breaks the
WANT_LGTMimplementation into small, reviewable steps:WANT_LGTM=body parsernot-inquery filterStack created with GitHub Stacks CLI • Give Feedback 💬