Repository navigation
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces the WantLgtmReconciler class and its corresponding unit tests to orchestrate the atomic, race-free reconciliation of WANT_LGTM check runs on pull requests. Feedback suggests adding a guard condition in _handleDirectiveRemoved to avoid redundant GitHub API calls and Firestore writes if the check run is already completed and neutral.
jtmcdole
force-pushed
the
want-lgtm-09-reconciler
branch
2 times, most recently
from
November 9, 2026 22:10
52fb22c to
fb2863c
Compare
jtmcdole
force-pushed
the
want-lgtm-09-reconciler
branch
2 times, most recently
from
November 9, 2026 23:39
60efdfe to
cf9676b
Compare
jtmcdole
commented
Nov 10, 2026
- Adds WantLgtmReconciler orchestrating disabled, fast-path, and GraphQL snapshot flows. - Short-circuits non-directive, closed, and invalid-directive PRs without GraphQL calls. - Serializes concurrent in-process reconciliations per PR via withLock.
jtmcdole
force-pushed
the
want-lgtm-09-reconciler
branch
from
November 10, 2026 00:07
cf9676b to
c221087
Compare
jtmcdole
commented
Nov 10, 2026
jtmcdole
commented
Nov 10, 2026
… 'feature disabled' - Remove in-process _locks and withLock in favor of PullRequestManager.runWithPrLock. - Guard _handleDirectiveRemoved when existingState is already completed and neutral. - Use 'feature disabled' instead of 'feature rolled back' when rollout flag is off.
This was referenced Nov 10, 2026
jtmcdole
marked this pull request as ready for review
November 10, 2026 19:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
WantLgtmReconcilerfor disabled-repo waivers, GraphQL snapshot evaluation, and neutral merge-group waivers. Skips GraphQL fast-path checks when no directive is active or syntax is invalid.WANT_LGTMStack (RFC 610.0001)Breaks the
WANT_LGTMimplementation into small, reviewable steps:WANT_LGTM=body parsernot-inquery filterStack created with GitHub Stacks CLI • Give Feedback 💬