Repository navigation
Conversation
- Adds WantLgtmFlags with global kill-switch, repo allowlist, and useForAllRepos. - Wires WantLgtmFlags into DynamicConfig and updates config.yaml. - Declares Config.kWantLgtmCheckName = 'WANT_LGTM'.
There was a problem hiding this comment.
Code Review
This pull request introduces the WANT_LGTM check configuration and flags to block pull request merges until all requested or explicit reviewers have approved. It adds the WantLgtmFlags class, integrates it into DynamicConfig, and includes corresponding unit tests. The review feedback suggests optimizing repository lookups in WantLgtmFlags by pre-lowercasing the enabledRepos list during construction and using a direct contains check in isEnabledForRepo.
This was referenced Nov 10, 2026
jtmcdole
marked this pull request as ready for review
November 10, 2026 19:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
WantLgtmFlags(enabled,useForAllRepos, andenabledRepos) toDynamicConfigwith safe disabled defaults inconfig.yaml, and declaresConfig.kWantLgtmCheckName = 'WANT_LGTM'.WANT_LGTMStack (RFC 610.0001)Breaks the
WANT_LGTMimplementation into small, reviewable steps:WANT_LGTM=body parsernot-inquery filterStack created with GitHub Stacks CLI • Give Feedback 💬