Skip to content

feat(want_lgtm): add rollout flags and dynamic config wiring - #5175

Open
jtmcdole wants to merge 1 commit into
want-lgtm-01-refactorfrom
want-lgtm-02-flags
Open

jtmcdole wants to merge 1 commit into
want-lgtm-01-refactorfrom
want-lgtm-02-flags

Conversation

@jtmcdole

@jtmcdole jtmcdole commented Nov 9, 2026 •

Copy link
Copy Markdown
Member

Adds WantLgtmFlags (enabled, useForAllRepos, and enabledRepos) to DynamicConfig with safe disabled defaults in config.yaml, and declares Config.kWantLgtmCheckName = 'WANT_LGTM'.

WANT_LGTM Stack (RFC 610.0001)

Breaks the WANT_LGTM implementation into small, reviewable steps:

# PR Focus
1 #5174 Merge-group & check-run prep
2 #5175 Rollout flags & dynamic config ← you are here
3 #5176 Directive, verdict & snapshot models
4 #5177 WANT_LGTM= body parser
5 #5178 Review cohort evaluator
6 #5179 Firestore state & review webhook models
7 #5180 Paginated GraphQL snapshot client
8 #5181 GitHub check-run writer & cache
9 #5182 PR & merge-group reconciler
10 #5183 Webhook routing & Gold bypass
11 #5188 Firestore not-in query filter
12 #5184 Rollback check-run sweeper

Stack created with GitHub Stacks CLI • Give Feedback 💬

- Adds WantLgtmFlags with global kill-switch, repo allowlist, and useForAllRepos.
- Wires WantLgtmFlags into DynamicConfig and updates config.yaml.
- Declares Config.kWantLgtmCheckName = 'WANT_LGTM'.
@jtmcdole
jtmcdole added this pull request to stack #5185 November 9, 2026 19:28

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the WANT_LGTM check configuration and flags to block pull request merges until all requested or explicit reviewers have approved. It adds the WantLgtmFlags class, integrates it into DynamicConfig, and includes corresponding unit tests. The review feedback suggests optimizing repository lookups in WantLgtmFlags by pre-lowercasing the enabledRepos list during construction and using a direct contains check in isEnabledForRepo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant