Repository navigation
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces the evaluateWantLgtm service and its corresponding unit tests to evaluate a pull request's review status against a parsed WANT_LGTM= directive. The reviewer suggests refactoring if-else blocks checking TimelineReviewAction into exhaustive switch statements in both _resolveAllCohort and _findUnremovedTimelineRequest to leverage Dart 3's exhaustiveness checking for improved safety and maintainability.
jtmcdole
force-pushed
the
want-lgtm-05-evaluator
branch
from
November 9, 2026 21:56
fb99d13 to
79ec8a3
Compare
- Adds evaluateWantLgtm implementing RFC 610.0001 Section 3.3 truth table. - Enforces strict timeline ordering for re-requested reviews after approval. - Excludes PR author and roller accounts from cohorts and caps check titles at 255 chars.
jtmcdole
force-pushed
the
want-lgtm-05-evaluator
branch
from
November 9, 2026 22:10
79ec8a3 to
553826d
Compare
jtmcdole
commented
Nov 9, 2026
jtmcdole
commented
Nov 9, 2026
- Rename _capTitle to _clampTitleLength. - Switch TimelineReviewAction checks to exhaustive switch statements. - Use collection-for loops instead of spread .map() calls.
This was referenced Nov 10, 2026
jtmcdole
marked this pull request as ready for review
November 10, 2026 19:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
evaluateWantLgtmimplementing the RFC 610.0001 review verdict rules. Tracks timeline ordering when reviews are re-requested after a prior approval, excludes the PR author and roller accounts, and clamps check-run titles to 255 characters.WANT_LGTMStack (RFC 610.0001)Breaks the
WANT_LGTMimplementation into small, reviewable steps:WANT_LGTM=body parsernot-inquery filterStack created with GitHub Stacks CLI • Give Feedback 💬