Repository navigation
Conversation
…odels - Defines ParsedWantLgtmDirective (No, Valid, Invalid) with canonical storage formatting. - Defines WantLgtmVerdict (Satisfied, Pending, Invalid) and review/timeline records. - Adds WantLgtmGraphQLSnapshot immutable evaluation input container.
There was a problem hiding this comment.
Code Review
This pull request introduces domain models and corresponding unit tests for the WANT_LGTM service, defining structures for parsed directives, review records, timeline events, GraphQL snapshots, and evaluation verdicts. The feedback suggests implementing value equality (operator ==), hashCode, and toString() for the @immutable class WantLgtmGraphQLSnapshot to ensure consistency with other models, along with adding unit tests to verify this behavior.
jtmcdole
commented
Nov 9, 2026
Member
Author
There was a problem hiding this comment.
Its a lot of machinery / models, but I think it makes things easier to ready outside of want_lgtm
This was referenced Nov 10, 2026
jtmcdole
marked this pull request as ready for review
November 10, 2026 19:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defines the sealed
ParsedWantLgtmDirective(No,Valid,Invalid) andWantLgtmVerdict(Satisfied,Pending,Invalid) types, along with the immutableWantLgtmGraphQLSnapshotvalue object.WANT_LGTMStack (RFC 610.0001)Breaks the
WANT_LGTMimplementation into small, reviewable steps:WANT_LGTM=body parsernot-inquery filterStack created with GitHub Stacks CLI • Give Feedback 💬