Skip to content

feat(want_lgtm): add sealed directive, verdict, and snapshot domain models - #5176

Open
jtmcdole wants to merge 2 commits into
want-lgtm-02-flagsfrom
want-lgtm-03-models
Open

jtmcdole wants to merge 2 commits into
want-lgtm-02-flagsfrom
want-lgtm-03-models

Conversation

@jtmcdole

@jtmcdole jtmcdole commented Nov 9, 2026 •

Copy link
Copy Markdown
Member

Defines the sealed ParsedWantLgtmDirective (No, Valid, Invalid) and WantLgtmVerdict (Satisfied, Pending, Invalid) types, along with the immutable WantLgtmGraphQLSnapshot value object.

WANT_LGTM Stack (RFC 610.0001)

Breaks the WANT_LGTM implementation into small, reviewable steps:

# PR Focus
1 #5174 Merge-group & check-run prep
2 #5175 Rollout flags & dynamic config
3 #5176 Directive, verdict & snapshot models ← you are here
4 #5177 WANT_LGTM= body parser
5 #5178 Review cohort evaluator
6 #5179 Firestore state & review webhook models
7 #5180 Paginated GraphQL snapshot client
8 #5181 GitHub check-run writer & cache
9 #5182 PR & merge-group reconciler
10 #5183 Webhook routing & Gold bypass
11 #5188 Firestore not-in query filter
12 #5184 Rollback check-run sweeper

Stack created with GitHub Stacks CLI • Give Feedback 💬

…odels

- Defines ParsedWantLgtmDirective (No, Valid, Invalid) with canonical storage formatting.
- Defines WantLgtmVerdict (Satisfied, Pending, Invalid) and review/timeline records.
- Adds WantLgtmGraphQLSnapshot immutable evaluation input container.
@jtmcdole
jtmcdole added this pull request to stack #5185 November 9, 2026 19:28

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces domain models and corresponding unit tests for the WANT_LGTM service, defining structures for parsed directives, review records, timeline events, GraphQL snapshots, and evaluation verdicts. The feedback suggests implementing value equality (operator ==), hashCode, and toString() for the @immutable class WantLgtmGraphQLSnapshot to ensure consistency with other models, along with adding unit tests to verify this behavior.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a lot of machinery / models, but I think it makes things easier to ready outside of want_lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant