Repository navigation
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces the WantLgtmCheckWriter class to translate WANT_LGTM evaluation verdicts into GitHub Check Runs and persist their state in Firestore, along with comprehensive unit tests. Feedback on the implementation highlights a few key issues: first, started_at should be omitted when referencing an existing check run by ID to avoid resetting the check run's start time on GitHub; second, both writeWaivedCheckRun and writeRolledBackCheckRun should explicitly update the checkRunId and headSha fields when mutating an existingState in place to prevent Firestore from storing outdated values.
jtmcdole
force-pushed
the
want-lgtm-08-check-writer
branch
from
November 9, 2026 21:56
bea4f1a to
8d46796
Compare
jtmcdole
force-pushed
the
want-lgtm-08-check-writer
branch
from
November 9, 2026 22:10
8d46796 to
262e88c
Compare
jtmcdole
force-pushed
the
want-lgtm-08-check-writer
branch
from
November 9, 2026 22:41
262e88c to
e33ff49
Compare
jtmcdole
commented
Nov 9, 2026
- Adds WantLgtmCheckWriter mapping verdicts to GitHub CheckRun status/conclusions. - Suppresses redundant PATCH requests and Firestore writes on unchanged verdicts. - Spawns a fresh check run on same-SHA completed -> in_progress reopens. - Supports merge-group, directive-removed, closed-PR, and rollback neutral waivers.
jtmcdole
force-pushed
the
want-lgtm-08-check-writer
branch
from
November 9, 2026 23:39
e33ff49 to
be90fd0
Compare
…ify check run lifecycle
This was referenced Nov 10, 2026
jtmcdole
marked this pull request as ready for review
November 10, 2026 19:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
WantLgtmCheckWriterto write GitHub Check Runs and persistWantLgtmState. Skips unchanged PATCH calls, recreates completed runs when reopened to pending, and writes neutral waivers.WANT_LGTMStack (RFC 610.0001)Breaks the
WANT_LGTMimplementation into small, reviewable steps:WANT_LGTM=body parsernot-inquery filterStack created with GitHub Stacks CLI • Give Feedback 💬